----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41850/#review112508 -----------------------------------------------------------
It is suggested to use past tone for the Summary and please also add a period to the end of the Summary. src/slave/slave.hpp (line 576) <https://reviews.apache.org/r/41850/#comment172968> s/If there's not enough resources,/If there are not enough resources for tasks requesting stateless reserved resources src/slave/slave.cpp (line 3864) <https://reviews.apache.org/r/41850/#comment172969> This should be in another patch? - Guangya Liu On Jan. 3, 2016, 2:31 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41850/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2016, 2:31 a.m.) > > > Review request for mesos and Guangya Liu. > > > Bugs: MESOS-3892 > https://issues.apache.org/jira/browse/MESOS-3892 > > > Repository: mesos > > > Description > ------- > > Before getting evictable executors for evicting, it need to trace which > execuotor can be evicted. > > > Diffs > ----- > > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c > > Diff: https://reviews.apache.org/r/41850/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >
