> On Nov. 4, 2015, 6:08 p.m., Michael Hopcroft wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp,
> >  line 199
> > <https://reviews.apache.org/r/39803/diff/2/?file=1113682#file1113682line199>
> >
> >     Recommend using RAII pattern (e.g. std::unique_ptr) to eliminate 
> > leaking of reparsePointData in the presense of exceptions or logic errors.
> >     
> >     Since this is C++ code, recommend using new [] instead of malloc/free.
> 
> Alex Clemmer wrote:
>     I am somewhat embarrassed to admit that, being a C++ noob, I need you to 
> double-check that I got this right: we want to do `new 
> REPARSE_DATA_BUFFER[MAXIMUM_REPARSE_DATA_BUFFER_SIZE]` to allocate a union of 
> size `MAXIMUM_REPARSE_DATA_BUFFER_SIZE`, right?
>     
>     I'm keeping this issue open so you can confirm. I was not even aware we 
> could do this in C++, and after some Googling, I did not find specific 
> confirmation that this is the semantics of this expression.

I didn't type that code segment correctly before I hit publish, alas. Have a 
look at the code, though, and tell me what you think.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review105083
-----------------------------------------------------------


On Jan. 4, 2016, 11:33 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 11:33 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
>  PRE-CREATION 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
> 5b38b9af654d7d1c574f0cc573083b66693ced1d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to