----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41909/#review112738 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 81 - 82) <https://reviews.apache.org/r/41909/#comment173223> Can you move the comments right above: ``` if (executorInfo.container().mesos().has_image()) { ``` src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 91 - 93) <https://reviews.apache.org/r/41909/#comment173224> In fact, we don't support executorInfo.container().volumes() at all. Let's disallow that as well: ``` if (!executorInfo.container().volumes().empty()) { return Failure("Volumes in ContainerInfo is not supported"); } ``` - Jie Yu On Jan. 5, 2016, 1:06 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41909/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 1:06 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4290 > https://issues.apache.org/jira/browse/MESOS-4290 > > > Repository: mesos > > > Description > ------- > > Fixed posix filesystem isolator to not allow executors with image. > Note that command tasks with image also creates a volume in the executor > info, so this check should handle both command tasks and custom executors. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca > > Diff: https://reviews.apache.org/r/41909/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
