-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41871/#review112799
-----------------------------------------------------------

Ship it!


The change itself looks great. My only concern is that we should briefly 
discuss this on the dev mailing whether there are any potential problems as we 
are adding a new tool to our buildchain.


configure.ac (line 46)
<https://reviews.apache.org/r/41871/#comment173296>

    General comment: As this adds another tool to our build chain, should we 
have a brief discussion on the dev mailing list?


- Joerg Schad


On Jan. 4, 2016, 8:01 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41871/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 8:01 p.m.)
> 
> 
> Review request for mesos, Joerg Schad, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4271
>     https://issues.apache.org/jira/browse/MESOS-4271
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The added m4 macro definitions come from
> git://anongit.freedesktop.org/git/dolt revision
> 2eae53fa6d31175e9de62a312cc2191fd8a25cb7.
> 
> 
> Diffs
> -----
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
>   m4/dolt.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41871/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to