----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review112802 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (line 107) <https://reviews.apache.org/r/41593/#comment173298> Here and in all dtrs below: Given that we don't know whether exceptions are enabled for `stream` (this is stout), could we wrap this in a `try` block?, e.g., imagine an underlying `fstream` becoming `bad` because there is no space left on the device. - Benjamin Bannier On Jan. 4, 2016, 11:39 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41593/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 11:39 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/README.md > a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 > > Diff: https://reviews.apache.org/r/41593/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
