----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40966/#review112812 -----------------------------------------------------------
Thanks Jan! Seems it needs a rebase though? ``` ../../src/tests/health_check_tests.cpp:312:27: error: no matching constructor for initialization of 'mesos::internal::tests::MockDockerContainerizer' MockDockerContainerizer containerizer(flags, &fetcher, docker); ^ ~~~~~~~~~~~~~~~~~~~~~~~ ../../src/tests/mesos.hpp:1046:3: note: candidate constructor not viable: requires 4 arguments, but 3 were provided MockDockerContainerizer( ``` src/tests/health_check_tests.cpp (line 265) <https://reviews.apache.org/r/40966/#comment173304> Insert a blank line, please. - Till Toenshoff On Jan. 5, 2016, 10:43 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40966/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 10:43 a.m.) > > > Review request for mesos, Greg Mann, haosdent huang, Jojy Varghese, Till > Toenshoff, and Timothy Chen. > > > Bugs: MESOS-4025 > https://issues.apache.org/jira/browse/MESOS-4025 > > > Repository: mesos > > > Description > ------- > > Tests cases have to wait until a container has been terminated by the > DockerContainerizer. Otherwise there could be artifacts (e.g. locked cgroups) > that can affect later test cases (see MESOS-4025, where cgroups couldn't be > removed). > > > Diffs > ----- > > src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02 > > Diff: https://reviews.apache.org/r/40966/diff/ > > > Testing > ------- > > make check > sudo ./bin/mesos-tests.sh --gtest_repeat=50 > --gtest_filter="HealthCheckTest.ROOT_DOCKER_*:SlaveRecoveryTest*GCExecutor" > > > Thanks, > > Jan Schlicht > >