> On Dec. 28, 2015, 12:41 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 1072 > > <https://reviews.apache.org/r/41550/diff/1/?file=1170874#file1170874line1072> > > > > No need to introduce a variable if it used just once. > > Jan Schlicht wrote: > `EXPECT_EQ` does not like `DEFAULT_CREDENTIAL.principal()` as an argument > -- has to do with the way `DEFAULT_CREDENTIAL` is constructed. I will add a > comment to explain why the variable is introduced here.
Interesting. Okay! - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41550/#review111973 ----------------------------------------------------------- On Jan. 5, 2016, 11:17 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41550/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 11:17 a.m.) > > > Review request for mesos, Alexander Rukletsov and Till Toenshoff. > > > Bugs: MESOS-4083 > https://issues.apache.org/jira/browse/MESOS-4083 > > > Repository: mesos > > > Description > ------- > > Quota Authorization: Added tests for quota removal authorization. > > > Diffs > ----- > > src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 > src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 > > Diff: https://reviews.apache.org/r/41550/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
