> On Jan. 5, 2016, 7:49 p.m., Till Toenshoff wrote: > >
Thanks Till! > On Jan. 5, 2016, 7:49 p.m., Till Toenshoff wrote: > > src/tests/registrar_tests.cpp, line 909 > > <https://reviews.apache.org/r/41622/diff/2/?file=1182172#file1182172line909> > > > > Seems `std::set` also can lose that namespace. I originally got rid of `std::` here, but got a compile-time error. It looks like the namespace is necessary to disambiguate with the `set` member of the mock (see lines above). > On Jan. 5, 2016, 7:49 p.m., Till Toenshoff wrote: > > src/tests/registrar_tests.cpp, line 65 > > <https://reviews.apache.org/r/41622/diff/2/?file=1182172#file1182172line65> > > > > Not used!? This was used at the very end of the file, but we should be using `LOG` instead. Fixed. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41622/#review112908 ----------------------------------------------------------- On Jan. 5, 2016, 8:06 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41622/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 8:06 p.m.) > > > Review request for mesos, Adam B and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Removed unnecessary std namespaces from registrar tests. > > > Diffs > ----- > > src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 > > Diff: https://reviews.apache.org/r/41622/diff/ > > > Testing > ------- > > `GTEST_FILTER="*Registrar*" bin/mesos-tests.sh` > > > Thanks, > > Greg Mann > >
