> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 226
> > <https://reviews.apache.org/r/41460/diff/1/?file=1166979#file1166979line226>
> >
> >     I'd love to see a comment here that says:
> >     
> >     This is the less prefered `onReady`, we prefer the `onReady` method 
> > which has `f` taking a `const T&` parameter. Unfortunately, to complicate 
> > matters, if `F` is a `std::bind` expression we need to SFINAE out this 
> > version of `onReady` and force the use of the preferred `onReady` (which 
> > thankfully works because `std::bind` will just ignore the `const T&` 
> > argument). This is necessary because Visual Studio 2015 doesn't support 
> > using the `std::bind` call operator with `std::result_of` as it's 
> > technically not a requirement by the C++ standard.
> >     
> >     And then let's add a comment over the other `LessPrefer` variants that 
> > points up to the `onReady(F f, LessPrefer)` that includes this comment.

Added.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41460/#review112480
-----------------------------------------------------------


On Jan. 5, 2016, 11:58 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41460/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4228
>     https://issues.apache.org/jira/browse/MESOS-4228
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Standard (C++11 through 17) does not require `std::bind`'s function call 
> operator to SFINAE, and VS 2015's doesn't. `std::is_bind_expression` can be 
> used to manually reroute bind expressions to the 1-arg overload, where 
> (conveniently) the argument will be ignored if necessary.
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41460/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to