----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41938/#review113034 -----------------------------------------------------------
src/tests/master_quota_tests.cpp (line 160) <https://reviews.apache.org/r/41938/#comment173525> Shouldn't this be SetNonExistentRole? src/tests/master_quota_tests.cpp (line 297) <https://reviews.apache.org/r/41938/#comment173527> SetResourcesSpecifyRole? - Joerg Schad On Jan. 5, 2016, 11:39 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41938/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 11:39 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > ------- > > Changes made: > - removed extra ';' in resources string; > - renamed variables for clarity; > - updated comments; > - removed explicit conversion to `Resources`; > - wrapped test cases in {} blocks. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 > src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 > > Diff: https://reviews.apache.org/r/41938/diff/ > > > Testing > ------- > > `make check` on Mac OS 10.10.5 > > > Thanks, > > Alexander Rukletsov > >
