-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42002/#review113156
-----------------------------------------------------------

Ship it!


Ship It!


include/mesos/master/allocator.hpp (line 157)
<https://reviews.apache.org/r/42002/#comment173657>

    Not you, but I'd say "This will", not "It will".


- Neil Conway


On Jan. 7, 2016, 12:47 a.m., Adam B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42002/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 12:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Guangya Liu, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated missing allocator comments and removed redundancies.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb33333d6 
> 
> Diff: https://reviews.apache.org/r/42002/diff/
> 
> 
> Testing
> -------
> 
> JAVADOC_AUTOBRIEF=YES means that the brief description stops at the first 
> '.', so we don't really need a newline or blank line in between brief and 
> detailed descriptions.
> Also, REPEAT_BRIEF=YES means that the brief description is prepended to the 
> detailed description, so there's no need to repeat it ourselves.
> 
> I mostly wanted to get rid of gyliu513's TODOs, but got frustrated with the 
> useless comment : function definition ratio.
> 
> 
> Thanks,
> 
> Adam B
> 
>

Reply via email to