> On Jan. 7, 2016, 3:39 a.m., Anand Mazumdar wrote: > > support/docker_build.sh, line 69 > > <https://reviews.apache.org/r/42011/diff/2/?file=1185748#file1185748line69> > > > > Nit: Newline before this line. > > > > Also can you add a comment before this line like we have for other > > lines: > > > > # Generate XML test report.
thanks, fixed! - Shuai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113178 ----------------------------------------------------------- On Jan. 7, 2016, 2:44 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42011/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 2:44 a.m.) > > > Review request for mesos, Ben Mahler and haosdent huang. > > > Bugs: MESOS-4258 > https://issues.apache.org/jira/browse/MESOS-4258 > > > Repository: mesos > > > Description > ------- > > Added gtest flags to generate xml report > > > Diffs > ----- > > Makefile.am d9604f48f194dc8272423410e9938e646f334a9c > support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e > > Diff: https://reviews.apache.org/r/42011/diff/ > > > Testing > ------- > > $ export GTEST_OUTPUT=xml:report.xml > $ make check > $ find . -name report.xml > > > ./3rdparty/libprocess/report.xml > ./3rdparty/libprocess/3rdparty/report.xml > ./src/report.xml > > > Thanks, > > Shuai Lin > >
