----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review113227 -----------------------------------------------------------
Ship it! Committing this now, with the below change. src/tests/slave_tests.cpp (lines 1386 - 1387) <https://reviews.apache.org/r/40429/#comment173727> This struck me as oddly unrelated at first, but I foolishly ignored it. When I ran make check with your changes, I got: ``` [01:48:57][Step 8/10] [ RUN ] SlaveTest.TerminatingSlaveDoesNotReregister [01:48:57][Step 8/10] 2016-01-06 01:48:57,354:31060(0x7f7620f46700):ZOO_ERROR@handle_socket_error_msg@1697: Socket [127.0.0.1:41955] zk retcode=-4, errno=111(Connection refused): server refused to accept the client [01:48:57][Step 8/10] ../../src/tests/slave_tests.cpp:1386: Failure [01:48:57][Step 8/10] Actual function call count doesn't match EXPECT_CALL(sched, offerRescinded(&driver, _))... [01:48:57][Step 8/10] Expected: to be called once [01:48:57][Step 8/10] Actual: never called - unsatisfied and active [01:48:57][Step 8/10] [ FAILED ] SlaveTest.TerminatingSlaveDoesNotReregister (129 ms) ``` Which makes me think we should leave out the `offerRescinded` change to this test, and address the test's flakiness separately, in MESOS-3509. - Adam B On Jan. 5, 2016, 11:01 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40429/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 11:01 a.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-313 > https://issues.apache.org/jira/browse/MESOS-313 > > > Repository: mesos > > > Description > ------- > > Report executor exit to framework schedulers. This is a MVP to start the work > of notifying scheduler on scheduler refresh. > > Next step would be sending this message reliabily, and/or splitting > Event::FAILURE for slave failure and executor termination. > > > Diffs > ----- > > CHANGELOG 2aa083c85ae2a2f1392121b1d30d71376c01ffd7 > docs/app-framework-development-guide.md > 4a43a93d080bdac37b8aee91748fea7552a1cc67 > docs/upgrades.md aebdc1e1b7a73c93b5a14867214eb852de89ad24 > include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 > src/java/src/org/apache/mesos/Scheduler.java > 4f048830a2c47f747033c60730cc770cb2578815 > src/python/interface/src/mesos/interface/__init__.py > 4be502fd83029ad5fc798696caf9e27fd95f7482 > src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c > src/tests/fault_tolerance_tests.cpp > ba657d0e1d8515cffd1b37925bf91a84b2feaef1 > src/tests/gc_tests.cpp f939d27c58177fba052fbcd9d6c9a572d052df52 > src/tests/master_slave_reconciliation_tests.cpp > 9afa826006fa7129da1a9c1ac8c389c0e051f717 > src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 > src/tests/scheduler_event_call_tests.cpp > 03f0332ef75bbe7c4947bd6daf55d40384570f18 > src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0 > > Diff: https://reviews.apache.org/r/40429/diff/ > > > Testing > ------- > > Modified test for SchedulerDriverEventTest.Failure, which verifies that > MockScheduler::executorLost is invoked. > > > Thanks, > > Zhitao Li > >
