-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41781/#review113369
-----------------------------------------------------------

Ship it!



src/tests/container_logger_tests.cpp (lines 28 - 30)
<https://reviews.apache.org/r/41781/#comment173947>

    How come these aren't pulled out since they are three levels?



src/tests/container_logger_tests.cpp (line 172)
<https://reviews.apache.org/r/41781/#comment173944>

    s/agent_flags/flags/



src/tests/container_logger_tests.cpp (line 184)
<https://reviews.apache.org/r/41781/#comment173945>

    s/agent/slave/
    
    I thought this is what we decided to do with the previous reviews too?



src/tests/container_logger_tests.cpp (line 241)
<https://reviews.apache.org/r/41781/#comment173946>

    s/sandboxPath/sandboxDirectory/
    
    Isn't that what we decided before? Or not?


- Benjamin Hindman


On Jan. 5, 2016, 5:32 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41781/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
>     https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test loads a non-default ContainerLogger module that rotates logs (i.e. 
> renaming the head log file) and constrains total log size.
> 
> 
> Diffs
> -----
> 
>   src/tests/container_logger_tests.cpp 
> c6b2e597517c74a55649287dc5ae5a3115f9a640 
> 
> Diff: https://reviews.apache.org/r/41781/diff/
> 
> 
> Testing
> -------
> 
> This test is run later in the review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to