> On 一月 7, 2016, 7:04 p.m., Joseph Wu wrote: > > include/mesos/resources.hpp, line 166 > > <https://reviews.apache.org/r/41334/diff/7/?file=1185995#file1185995line166> > > > > s/ revocable/, resources reserved but not allocated/
Done > On 一月 7, 2016, 7:04 p.m., Joseph Wu wrote: > > include/mesos/resources.hpp, lines 167-168 > > <https://reviews.apache.org/r/41334/diff/7/?file=1185995#file1185995line167> > > > > Can you make it clear that this "role" is for the slack, rather than > > the original role the resource is reserved for? Done - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/#review113289 ----------------------------------------------------------- On 一月 7, 2016, 7:40 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41334/ > ----------------------------------------------------------- > > (Updated 一月 7, 2016, 7:40 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and Klaus Ma. > > > Bugs: MESOS-4146 > https://issues.apache.org/jira/browse/MESOS-4146 > > > Repository: mesos > > > Description > ------- > > This helper function is used to filter out allocation slack resources. > > > Diffs > ----- > > include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa > include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c > src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc > > Diff: https://reviews.apache.org/r/41334/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
