----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41878/#review113413 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp (lines 403 - 404) <https://reviews.apache.org/r/41878/#comment174040> Not yours, but can we actually fix the overflow issue here? We should rearrange these conditions such that we don't end up doing `seconds * SECONDS` which can overflow. - Michael Park On Jan. 5, 2016, 8:23 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41878/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 8:23 a.m.) > > > Review request for mesos, Michael Park and Jan Schlicht. > > > Bugs: MESOS-4275 > https://issues.apache.org/jira/browse/MESOS-4275 > > > Repository: mesos > > > Description > ------- > > Type long has different widths under e.g., 32- and 64-bit > architectures. Since we already use fixed width types internally in most > places update these remaining uses. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp > dc610e697032f0d5d9c7a6524aeb34984041dec7 > > Diff: https://reviews.apache.org/r/41878/diff/ > > > Testing > ------- > > make check (OS X 10.10.5) > > > Thanks, > > Benjamin Bannier > >
