----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/#review113430 -----------------------------------------------------------
src/slave/slave.cpp (line 3963) <https://reviews.apache.org/r/41857/#comment174066> s/pinding/pending src/slave/slave.cpp (line 3967) <https://reviews.apache.org/r/41857/#comment174067> this check may not be necessary because resources cannot be negative? src/slave/slave.cpp (line 3985) <https://reviews.apache.org/r/41857/#comment174079> I am not sure whether this situation will happen, because it means a task using allocation slack and is waiting for evicting executor. Master should not allowed such task to be launched beacause there not enough available allocation slack resources for this task - Jian Qiu On 一月 8, 2016, 6:54 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41857/ > ----------------------------------------------------------- > > (Updated 一月 8, 2016, 6:54 a.m.) > > > Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris > Van Remoortere, Joseph Wu, and Jian Qiu. > > > Bugs: MESOS-3892 > https://issues.apache.org/jira/browse/MESOS-3892 > > > Repository: mesos > > > Description > ------- > > get evictable executors > > > Diffs > ----- > > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f > > Diff: https://reviews.apache.org/r/41857/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >
