> On Jan. 4, 2016, 3:40 p.m., Guangya Liu wrote:
> > src/slave/slave.hpp, lines 392-400
> > <https://reviews.apache.org/r/41856/diff/2/?file=1180643#file1180643line392>
> >
> >     Can you please explain why not adding some global counters for 
> > totalAllocationSlack, pendingAllocationSlac, occupiedAllocationSlack etc?

That'll be too much counter in agent :). I'd like to move 
`getEvictableExecutors` to master after MESOS-1718; so make the code in a 
central place.


> On Jan. 4, 2016, 3:40 p.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 3937
> > <https://reviews.apache.org/r/41856/diff/2/?file=1180644#file1180644line3937>
> >
> >     Why account the queued task here? Does not this handled by 
> > framework->penging and framework->pendingExecutors?

We need to account queued tasks; in `_runTasks`, the tasks is moved from 
pending list to queuedTasks; the queued tasks will account into executor when 
`container->update` return


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/#review112512
-----------------------------------------------------------


On Jan. 8, 2016, 2:54 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41856/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 2:54 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris 
> Van Remoortere, Joseph Wu, and Jian Qiu.
> 
> 
> Bugs: MESOS-3892
>     https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Helper functions to get allocation slack
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
>   include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/41856/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to