> On Jan. 8, 2016, 11:48 a.m., Alexander Rojas wrote:
> > Can you please add unit tests in the same way of `hashset_tests.cpp` and 
> > `hashmap_tests.cpp`

I added new unit tests for List which will be added to the Makefile in the 
follow-up patch (Makefile for stout-tests lives in libprocess).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41875/#review113445
-----------------------------------------------------------


On Jan. 8, 2016, 12:29 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41875/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 12:29 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-4273
>     https://issues.apache.org/jira/browse/MESOS-4273
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Provided List constructor from std::initializer_list.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp 
> 864d8c9498d66f14ab6fc531965c12fb397b5fe5 
>   3rdparty/libprocess/3rdparty/stout/tests/list_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41875/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5 and Debian 8)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to