----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113532 -----------------------------------------------------------
Looks pretty good to me except for the potential bug in devolve (although I don't think we even use SlaveInfo.checkpoint for anything anymore). I still want to do a pass over the code to see if there's anything else we ought to remove. src/internal/devolve.cpp <https://reviews.apache.org/r/41649/#comment174270> BUG? Wouldn't you still need to `set_checkpoint(true)`, since the SlaveInfo.checkpoint protobuf defaults to false, and AgentInfo doesn't have 'checkpoint'? src/master/master.cpp (lines 1073 - 1075) <https://reviews.apache.org/r/41649/#comment174271> "The semantics when a registered slave gets disconnected are as follows for each framework running on that slave:" Actually, this whole comment block probably makes more sense above the foreach(frameworkIds) loop, where that "Remove all non-checkpointing frameworks" comment lives now src/master/master.cpp (line 1088) <https://reviews.apache.org/r/41649/#comment174272> Unnecessary comment? - Adam B On Jan. 8, 2016, 4:46 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41649/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 4:46 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff. > > > Bugs: MESOS-2317 > https://issues.apache.org/jira/browse/MESOS-2317 > > > Repository: mesos > > > Description > ------- > > Removed slave checkpointing logic after deprecation cycle. > > > Diffs > ----- > > include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 > src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba > src/examples/docker_no_executor_framework.cpp > 7b3f0581f75105addb388dc15c4a0390ae4e0e0e > src/examples/java/TestFramework.java > cbcdeedb0da22f82e274d088eb15a4128fd920fe > src/examples/python/test_framework.py > 6af6d22f54c0ad702917d09cf658e70f7032d793 > src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678 > src/master/allocator/mesos/hierarchical.hpp > 86ea5a402ed67f8f22f11d5730147cd907d66a08 > src/master/allocator/mesos/hierarchical.cpp > df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 > src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 > src/slave/containerizer/containerizer.hpp > 6964d136818ea9904fa35cd778eb9ef19e2c64fc > src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee > src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c > src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd > src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 > > Diff: https://reviews.apache.org/r/41649/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
