This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 8, 2016, 5:58 p.m.)

Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van 


Re-implemented the top of `Master::accept` based on what we (Joris/BenM/I) 
discussed offline.  This splits apart offers and inverse offers into separate 
arrays for validation and processing.

Summary (updated)

Updated and refactored Master::accept for Offers with InverseOffers.

Bugs: MESOS-4301

Repository: mesos

Description (updated)

Adds `validation::offer::inverse::validate` to validate inverse offers along 
the same lines as `validation::offer::validate`, except `SlaveId` is not 
validated for inverse offers.

Fixes and refactors `Master::accept` to allow `ACCEPT` calls that contain both 
offers and inverse offers.
Also tweaks `Master::accept` to not print a misleading log line "ACCEPT call 
used invalid offers ..." when the call only includes inverse offers.

Diffs (updated)

  include/mesos/type_utils.hpp efe2b1de0c277db62d7f7cc5ff1cd9143b9f632a 
  src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
  src/master/master.hpp f02d165874fa8023675e545793de699aeecae29b 
  src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 

Diff: https://reviews.apache.org/r/42086/diff/


make check

# Ran the following and checked for blank output:
bin/mesos-tests.sh --gtest_filter="*Inverse*Offer*" --verbose 2>&1 /dev/null |  
grep "ACCEPT call used invalid offers"

# Check new test for flakiness:
bin/mesos-tests.sh --gtest_filter="*OffersAndInverseOffers" --gtest_repeat=1500 


Joseph Wu

Reply via email to