----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42130/#review113709 -----------------------------------------------------------
src/tests/oversubscription_tests.cpp (line 1301) <https://reviews.apache.org/r/42130/#comment174515> Is this necessary? src/tests/oversubscription_tests.cpp (line 1365) <https://reviews.apache.org/r/42130/#comment174516> sleep 1000 shoule be enough? src/tests/oversubscription_tests.cpp (line 1374) <https://reviews.apache.org/r/42130/#comment174519> Do you need this? it needs an estimator, but it seems that you have not started slave with an estimator. And I don't think estimator is necessary in this test? - Jian Qiu On 一月 11, 2016, 7:52 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42130/ > ----------------------------------------------------------- > > (Updated 一月 11, 2016, 7:52 a.m.) > > > Review request for mesos, Guangya Liu and Jian Qiu. > > > Bugs: MESOS-3897 > https://issues.apache.org/jira/browse/MESOS-3897 > > > Repository: mesos > > > Description > ------- > > Added tests for `ALLOCATION_SLACK` helper functions. > > > Diffs > ----- > > src/tests/cluster.hpp 576dcb8b7e27d1905425aa0f7cb319c19c17c15c > src/tests/oversubscription_tests.cpp > 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a > > Diff: https://reviews.apache.org/r/42130/diff/ > > > Testing > ------- > > make > make check GTEST_FILTER="OversubscriptionTest.GetAllocationSlackHelpers" > > > Thanks, > > Klaus Ma > >
