> On Jan. 9, 2016, 1:05 a.m., Yi Sun wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp, line 55 > > <https://reviews.apache.org/r/39802/diff/3/?file=1128786#file1128786line55> > > > > So the entry is always pointing to the allocated memory when success.
Following up from our Slack conversation where I clarified your question: `entry` actually points at the current directory entry of `dir`, so a call to free is not necessary here. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review113581 ----------------------------------------------------------- On Jan. 4, 2016, 11:20 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39802/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 11:20 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented `stout/os/windows/ls.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/ls.hpp > 7dba79d31559d15a3e84eff506ce7df3e57cf5f3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp > 5b6fba13ce215af5801fd0867f6e774e100689ca > > Diff: https://reviews.apache.org/r/39802/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
