This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 11, 2016, 7:24 p.m.)

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Till Toenshoff, 
and Vinod Kone.


Use --git-common-dir instead of just --git-dir.

Summary (updated)

Using 'git rev-parse --git-common-dir' in post-reviews.py.

Bugs: MESOS-4125

Repository: mesos

Description (updated)

The post-reviews.py script has similar problems to the bootstrap script
in assuming that .git is a folder in the top-level directory of the git
repo.  This may not be true when mesos is included as a submodule in
another project. Use 'git rev-parse --git-common-dir' instead.

Review: https://reviews.apache.org/r/41244

Diffs (updated)

  support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e 

Diff: https://reviews.apache.org/r/41244/diff/


I have been posting all of my reviews with this script since first creating 
this commit. Tested both in an environment with and without mesos embedded as a 
submodule inside another git repository.


Kevin Klues

Reply via email to