----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42166/#review113881 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (lines 491 - 493) <https://reviews.apache.org/r/42166/#comment174657> How about: ``` // We treat 'null' as an unset field. Note that we allow // unset required fields here since the top-level parse // function is responsible for checking 'IsInitialized'. ``` - Ben Mahler On Jan. 11, 2016, 11:38 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42166/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 11:38 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van > Remoortere, Joseph Wu, and Timothy Chen. > > > Bugs: MESOS-4294 > https://issues.apache.org/jira/browse/MESOS-4294 > > > Repository: mesos > > > Description > ------- > > Fixed stout protobuf::parse to support JSON containing JSON::Null. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 > > Diff: https://reviews.apache.org/r/42166/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
