-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42167/#review113887
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (lines 335 - 337)
<https://reviews.apache.org/r/42167/#comment174669>

    How about:
    
    ```
            // TODO(gilbert): We currently push up the nested error
            // messages without wrapping the error message (due to
            // the recursive nature of parse). We should pass along
            // variable information in order to construct a helpful
            // error message, e.g. "Failed to parse field 'a.b.c': ...".
    ```



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (lines 342 - 343)
<https://reviews.apache.org/r/42167/#comment174671>

    Looks like we can just make do with the TODO above, rather than having 
these extra comments?



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 348)
<https://reviews.apache.org/r/42167/#comment174665>

    Can we avoid naming these variables after the if condition? How about 
'parse' for both of these?


- Ben Mahler


On Jan. 11, 2016, 11:39 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42167/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 11:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van 
> Remoortere, Joseph Wu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4311
>     https://issues.apache.org/jira/browse/MESOS-4311
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed stout protobuf::parse passing error message in nested JSON.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 
> 
> Diff: https://reviews.apache.org/r/42167/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to