> On Jan. 12, 2016, 2:03 a.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp, line 57
> > <https://reviews.apache.org/r/42106/diff/1/?file=1189254#file1189254line57>
> >
> >     Why is there a redundant `while` here?

It's used to avoid un-expected behaviour, for example:

    if (condition1)
        RETURN_ERROR_IF(...)
    else
        do something else


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42106/#review113804
-----------------------------------------------------------


On Jan. 9, 2016, 9:09 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42106/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2016, 9:09 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper function to return Error in condition.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp 1e9db7e 
> 
> Diff: https://reviews.apache.org/r/42106/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to