----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41879/#review113977 -----------------------------------------------------------
Patch looks great! Reviews applied: [41878, 41879] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 12, 2016, 6:57 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41879/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 6:57 a.m.) > > > Review request for mesos, Michael Park and Jan Schlicht. > > > Bugs: MESOS-4275 > https://issues.apache.org/jira/browse/MESOS-4275 > > > Repository: mesos > > > Description > ------- > > This constructor is not needed as we already provide a constructor which > can construct from a (value, unit) pair. This makes Duration > constructors more uniform. > > Review: https://reviews.apache.org/r/41879 > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp > 40b22604ec4eb01f44a36624bababb9b59d16bdb > > Diff: https://reviews.apache.org/r/41879/diff/ > > > Testing > ------- > > make check (OS X 10.10.5) > > > Thanks, > > Benjamin Bannier > >
