----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/#review114018 -----------------------------------------------------------
docs/logging.md (line 21) <https://reviews.apache.org/r/42172/#comment174813> Given that we use "module" in a different sense below, I'd avoid calling glog a "module". How about "Google's logging package" or "the Google logging package"? docs/logging.md (line 39) <https://reviews.apache.org/r/42172/#comment174811> Do we want <code> or back-ticks? Back-ticks would probably be more consistent with the other doc pages. docs/logging.md (line 77) <https://reviews.apache.org/r/42172/#comment174804> "that logs" docs/logging.md (line 87) <https://reviews.apache.org/r/42172/#comment174806> This is worded a little confusingly. Following the other flags, I'd say what the flag does first, and then say what the default value is. docs/logging.md (line 98) <https://reviews.apache.org/r/42172/#comment174807> For consistency, should be something like "Location of the externally managed log file." Also, maybe clarify that this doesn't actually control _where_ the log file is written; it is just for telling Mesos where (a different mechanism) has arranged for the file to appear. docs/logging.md (line 126) <https://reviews.apache.org/r/42172/#comment174814> Maybe clarify that `ContainerLogger` is a Mesos module, and link to the module documentation immediately? (I know we link below but we could make it more obvious.) Overall, looks good! - Neil Conway On Jan. 12, 2016, 1:07 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42172/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 1:07 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil > Conway. > > > Bugs: MESOS-4206 > https://issues.apache.org/jira/browse/MESOS-4206 > > > Repository: mesos > > > Description > ------- > > Moves (and updates) logging flags from `configuration.md` into the new > `logging.md`. > Adds documentation about logging in Master/Agent/Framework and the > `ContainerLogger`. > > Allows the doc-linking pattern of `[link text](other_doc.md#Link-to-text)`. > > > Diffs > ----- > > docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34 > docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16 > docs/logging.md PRE-CREATION > docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 > site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 > > Diff: https://reviews.apache.org/r/42172/diff/ > > > Testing > ------- > > Previewed on GitHub and via: > ``` > docker build -t mesos/website support/site-docker > docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website > ``` > > > Thanks, > > Joseph Wu > >
