-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42208/#review114102
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Jan. 12, 2016, 8:46 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42208/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 8:46 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joseph Wu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3472
>     https://issues.apache.org/jira/browse/MESOS-3472
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test previously used `Clock::now`. Because the effect of `Clock::advance`
> is not reset between test runs, every run of the complete test suite results 
> in
> advancing `Clock::now` by about four weeks. Hence, after running the test 
> suite
> ~12 times, `Clock::now` is ~one year ahead of the actual time, which broke an
> invariant in RegistryTokenTest.ExpiredToken.
> 
> It would be good to reset the clock to cancel the effect of any previous
> `Clock::advance` calls between test runs, but that will be more complicated. 
> So
> for now the test has been modified to just use a fixed time in the past.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 8d6a06057c7600aeb1aca76d4dfadc45b6eae99d 
> 
> Diff: https://reviews.apache.org/r/42208/diff/
> 
> 
> Testing
> -------
> 
> mesos-tests --gtest_repeat=25 --gtest_break_on_failure # fails 
> deterministically w/o patch
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to