----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/#review114100 -----------------------------------------------------------
We aren't porting the (deprecated) external containerizer to Windows right? There's a reference to `flags.switch_user` there, but it should be fine if we don't include it in the build. --- Also, in `src/slave/paths.cpp`, we reference the flag in a comment. Do you want add a comment there too? src/slave/flags.cpp (lines 206 - 207) <https://reviews.apache.org/r/42035/#comment174895> This is sort of weird, in that you only see this Windows note on non-Windows systems :) Maybe pull it out into a comment. - Joseph Wu On Jan. 7, 2016, 1:47 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42035/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 1:47 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Jie > Yu, and Joris Van Remoortere. > > > Bugs: MESOS-4310 > https://issues.apache.org/jira/browse/MESOS-4310 > > > Repository: mesos > > > Description > ------- > > The Mesos agent provides a flag, `--[no-]switch_user`, which instructs > the agent to run tasks as the user who submitted the task instead of the > user that is running the agent process itself. > > On POSIX, this requires the usual suspects (`su`, `chown`, and `chroot`, > for example to do things like make sure the correct user owns the > executor directory, and things like that. > > On Windows, many of these operations have very different semantics. To > use one example, to `chown` on Windows, you normally have to give > *permission* for something to `chown` an object, and then that thing > actually has to use that permission to `chown` it, on its own. > > Clearly a semantic mismatch of this magnitude will require some work to > formally bridge, and the result is that we will simply disable the > functionality entirely on the Windows agent until we are prepared to go > back and support it formally. > > > Diffs > ----- > > docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 > src/slave/flags.hpp 6857fde027fd57b4934cb43ddf435d12900e0b87 > src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526 > src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f > > Diff: https://reviews.apache.org/r/42035/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
