----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41882/#review114186 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 242 - 257) <https://reviews.apache.org/r/41882/#comment175010> Much slicker now, thanks for the suggestion Alexander! The comment helps understanding the ghist, gj! - Till Toenshoff On Jan. 13, 2016, 10:43 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41882/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 10:43 a.m.) > > > Review request for mesos, Benjamin Hindman and Till Toenshoff. > > > Bugs: MESOS-4278 > https://issues.apache.org/jira/browse/MESOS-4278 > > > Repository: mesos > > > Description > ------- > > To make the implementation less repetitive reimplemented `FlagsBase` > with a variadic template; this allows to now use an arbitrary number of > `FlagsBase` bases. > > Since `Flags<>` does already inherit virtually from `FlagsBase` it > should be a safer base class than `FlagsBase` for users. > > Review: https://reviews.apache.org/r/41882/ > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > addef78ddeb0007cf1e1c79738381138a18a35b6 > > Diff: https://reviews.apache.org/r/41882/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Bannier > >
