> On Jan. 13, 2016, 2:39 p.m., Bernd Mathiske wrote: > > src/tests/master_quota_tests.cpp, line 858 > > <https://reviews.apache.org/r/41939/diff/3/?file=1194831#file1194831line858> > > > > "true" -> Another place for FORCE. I suggest to declare it only once, > > globally, maybe as a constexpr.
This is a different place: if you take a look we send multiple requests inside this tests: one without force flag and one with. I would argue a constant here would reduce readability, while having an explicit "true" for the force flag in the second case increases the readability. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41939/#review114202 ----------------------------------------------------------- On Jan. 12, 2016, 9:33 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41939/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 9:33 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > ------- > > For clarity and in order not to distract a reader with copy-paste code: > - some tests were merged together; > - removed creation of agents where possible and used force flag > in quota request instead. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a > > Diff: https://reviews.apache.org/r/41939/diff/ > > > Testing > ------- > > `make check` on Mac OS 10.10.5 > > > Thanks, > > Alexander Rukletsov > >
