----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42221/#review114213 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 1256) <https://reviews.apache.org/r/42221/#comment175029> Not related to this patch, But I think `allocable()` is better than `empty()`. - Klaus Ma On Jan. 13, 2016, 7:06 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42221/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 7:06 a.m.) > > > Review request for mesos, Ben Mahler and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Since wDRF is encapsulated in the choice of sorter, it should not be > mentioned in the allocator code. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > > Diff: https://reviews.apache.org/r/42221/diff/ > > > Testing > ------- > > `make check` on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > >
