-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42215/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 9:37 p.m.)


Review request for mesos, Neil Conway and Timothy Chen.


Changes
-------

Added test names to the description.


Bugs: MESOS-4347
    https://issues.apache.org/jira/browse/MESOS-4347


Repository: mesos


Description (updated)
-------

Added expectations for call to mocked executor shutdown. The mock executor's 
shutdown method sometimes gets executed before the test exits, so it should be 
explicitly expected. Expectations were added to 
ReservationTest.ReserveAndLaunchThenUnreserve, 
ReservationTest.CompatibleCheckpointedResources, 
ReservationTest.CompatibleCheckpointedResourcesWithPersistentVolumes, 
ReservationTest.IncompatibleCheckpointedResources, and 
ReservationTest.ACLMultipleOperations.


Diffs
-----

  src/tests/reservation_tests.cpp 61d275c47fbb02baf22e4ad8f9b1580886da51d9 

Diff: https://reviews.apache.org/r/42215/diff/


Testing
-------

I used `GTEST_FILTER="ReservationTest.*" bin/mesos-tests.sh 
--gtest_repeat=10000 --gtest_break_on_failure=1 | grep -B 3 -A 6 WARNING` to 
reproduce the warnings, and then to verify that they were gone after the fix. 
Note that when running this command after the patch, other warning may be seen 
due to https://issues.apache.org/jira/browse/MESOS-4350


Thanks,

Greg Mann

Reply via email to