> On Dec. 17, 2015, 2:26 a.m., Till Toenshoff wrote: > > Ship It! > > Till Toenshoff wrote: > Something is off with your local post-reviews variant - note how the > description here shows `Review: https://reviews.apache.org/r/41411`. Seems a > slash is missing to make the pattern matching work. > > Kevin Klues wrote: > Hmm, my local variant is the same as https://reviews.apache.org/r/41244/, > which has very minimal changes to post-reviews.py. Glancing through this > script, it doesn't appear to do anything special with the commit message > before calling 'rbt' on it to post an update. Therefore, whatever the > current commit message is, will be passed verbatim to reviewboard, and with > the new "GUESS_FIELDS = "yes"", the descritption field will comtain the > contents of the commit message (including the Review: ...). To avoid this, > post-reviews.py would need to be patched to strip the "Review: ..." line from > the commit message before posting.
I've filed a follow-on patch to address this and strip the "Review: ..." line before posting: https://reviews.apache.org/r/42266/ - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41411/#review110858 ----------------------------------------------------------- On Dec. 15, 2015, 10:38 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41411/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 10:38 p.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-4180 > https://issues.apache.org/jira/browse/MESOS-4180 > > > Repository: mesos > > > Description > ------- > > Previously if you amended a commit message and posted it to reviewboard > via the support/post_reviews.py script, then the summary / description > on reviewboard would not be updated. The only way to update these was to > modify them directly on the webpage. However, with a simple directive in the > .reviewboardrc file we can force the review's summary / description to > be updated to the text in the commit message. This commit adds these > directives to the default .reviewboardrc. > > Review: https://reviews.apache.org/r/41411 > > > Diffs > ----- > > support/reviewboardrc 56bd8a59b1f3bed85241bdc133cc1127d4bff94d > > Diff: https://reviews.apache.org/r/41411/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
