-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42266/#review114376
-----------------------------------------------------------

Ship it!


The whole RBT amending now now works like a charm - thanks Kevin!

- Till Toenshoff


On Jan. 14, 2016, 1:29 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42266/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 1:29 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, when setting GUESS_FIELDS in .reviewboardrc to automatically
> update the summary message when posting a review, the summary would
> include the review URL in the summary message. This was due to the fact
> that GUESS_FILEDS simply copies the entirety of the commit message into
> the RR summary field on reviewboard. Including this line is both
> redundant, and, in some cases, has been found to appear (at least) twice
> in the summary message instead of just once.
> 
> This commit ensures that the commit message posted when GUESS_FIELDS is
> set will have the review URL stripped before posting.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e 
> 
> Diff: https://reviews.apache.org/r/42266/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to