----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42052/#review114404 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Hindman On Jan. 14, 2016, 1:55 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42052/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 1:55 a.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4136 > https://issues.apache.org/jira/browse/MESOS-4136 > > > Repository: mesos > > > Description > ------- > > Replaced `int pipefd[2]` with the structs `InputFileDescriptors` and > `OutputFileDescriptors`. > Replaced the `switch` statements inside `process::subprocess` with lambdas > defined in the static helpers (`PIPE`, `PATH`, `FD`). > > Slight cleanup of Subprocess code. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec > 3rdparty/libprocess/src/subprocess.cpp > 863523404b9ef1d2024c108f3e9e1c77c3916049 > > Diff: https://reviews.apache.org/r/42052/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
