----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42273/#review114441 -----------------------------------------------------------
Was the decision to optimize here driven by profiling? Given the proposed implementation I wonder if this was worth the risk. I can only see this being called for single element `queues` of `Events` which should not be too expensive to copy, especially given how little we worry about e.g., creating temporary `strings` elsewhere. - Benjamin Bannier On Jan. 14, 2016, 12:06 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42273/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 12:06 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This trivial fix invokes `std::move` on the `queue` object to not perform a > copy before invoking the `async(..)` call. > > > Diffs > ----- > > src/scheduler/scheduler.cpp a17872b46ec600e0fae6c43247ccb63f5ee55ac0 > > Diff: https://reviews.apache.org/r/42273/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
