> On 一月 14, 2016, 6:17 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 707-710 > > <https://reviews.apache.org/r/42113/diff/4/?file=1195640#file1195640line707> > > > > Should be > > > > if (freeAllocationSlack.empty()) > > break; > > > > Resources freeResources = freeAllocationSlack.get(name); > > > > if (freeResources.contains(unreservedResources)) { > > slaves[slaveId].total -= unreservedResources; > > freeAllocationSlack -= unreservedResources; > > } else { > > slaves[slaveId].total -= freeResources; > > freeAllocationSlack -= freeResources; > > }
The current logic is updating the `slave total` and always update `freeAllocationSlack` in every cycle. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/#review114419 ----------------------------------------------------------- On 一月 14, 2016, 12:46 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42113/ > ----------------------------------------------------------- > > (Updated 一月 14, 2016, 12:46 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > ------- > > Handle unreserve logic for dynamic reservation with allocation slack. > > This patch is halding the case when using updateAllocation to unreserve > some resources. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > d541bfa3f4190865c65d35c9d1ffdb8a3f194056 > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/42113/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
