-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41779/#review114484
-----------------------------------------------------------



3rdparty/libprocess/include/process/subprocess.hpp (line 126)
<https://reviews.apache.org/r/41779/#comment175337>

    I would suggest an enum {DUPLICATE, NO_DUPLICATE} instead of a bool. Then 
code readers do not have to look up the method definition at call sites to 
understand what "false" might mean. Nor do you have to put a comment at every 
call site explaining "false".


- Bernd Mathiske


On Jan. 13, 2016, 6:12 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41779/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
>     https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a subprocess is started with a FD, and the parent process does not need 
> the FD afterwards, the FD does not need to be duplicated.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec 
>   3rdparty/libprocess/src/subprocess.cpp 
> 863523404b9ef1d2024c108f3e9e1c77c3916049 
> 
> Diff: https://reviews.apache.org/r/41779/diff/
> 
> 
> Testing
> -------
> 
> Tests are run in the next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to