----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42313/#review114531 -----------------------------------------------------------
Ship it! src/uri/fetchers/hadoop.hpp (line 43) <https://reviews.apache.org/r/42313/#comment175381> This flag will be exposed as agent flags in the future. So let's add more context in the naming. Not yours, can you also rename 'hadoop' to 'hadoop_client'. ``` hadoop_client; hadoop_client_supported_schemes; ``` src/uri/fetchers/hadoop.cpp (lines 59 - 66) <https://reviews.apache.org/r/42313/#comment175384> Can you do the following: ``` vector<string> schemes = strings::tokenize(...); return set<string>(schmes.begin(), schmes.end()); ``` - Jie Yu On Jan. 14, 2016, 6:35 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42313/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 6:35 p.m.) > > > Review request for mesos, Adam B and Jie Yu. > > > Bugs: MESOS-4375 > https://issues.apache.org/jira/browse/MESOS-4375 > > > Repository: mesos > > > Description > ------- > > Allow schemes in HDFS URI fetcher plugin to be configurable. > > > Diffs > ----- > > src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e > src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1 > > Diff: https://reviews.apache.org/r/42313/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
