> On Jan. 14, 2016, 5:52 p.m., Artem Harutyunyan wrote: > > src/common/command_utils.cpp, lines 138-150 > > <https://reviews.apache.org/r/42274/diff/2/?file=1196123#file1196123line138> > > > > AFAIK tar can autodetect compression format. > > http://linux.livejournal.com/1872012.html
Not sure I follow. We need to provide flag to `tar` to specify the compression format during archiving (tar). For untarring, we need not. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42274/#review114510 ----------------------------------------------------------- On Jan. 13, 2016, 11:13 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42274/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 11:13 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This common file is a good place to add common command line utilities like > tar, > digests(sha256, sha512, etc). Currently this functionality is spread in the > code > base and this change would enable all those call sites to be replaced with a > common code. > > > Diffs > ----- > > src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 > src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 > src/common/command_utils.hpp PRE-CREATION > src/common/command_utils.cpp PRE-CREATION > src/tests/common/command_utils_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/42274/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
