----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42309/#review114526 -----------------------------------------------------------
bootstrap (line 35) <https://reviews.apache.org/r/42309/#comment175374> nit pick: `s/^the/The/` bootstrap (line 37) <https://reviews.apache.org/r/42309/#comment175375> As a weird corner case this makes it impossible to use `--git-common-dir` as name of the git common directory. I believe e.g., something like checking if `$_gitdir` existed would have worked at least as well for us. Also, I think this looks weird enough to justify a comment explaining why we do this. support/post-reviews.py (line 99) <https://reviews.apache.org/r/42309/#comment175376> Same issues here as in `bootstrap`. - Benjamin Bannier On Jan. 14, 2016, 6:56 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42309/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 6:56 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > The newly introduced way of finding the .git directory via > --git-common-dir is only supported on newer versions of git. Fallback to > the older --git-dir method if --git-common-dir is not supported. > > > Diffs > ----- > > bootstrap 519090d696ae09dac70318e91ade583b38f44048 > support/post-reviews.py ea361018ee77f55953af55038109148ed8057e44 > > Diff: https://reviews.apache.org/r/42309/diff/ > > > Testing > ------- > > Tested on mac el capitan and ubuntu 14.04 with both bash and dash and git > 2.6.3 and git 2.2.0 repsectively. > > > Thanks, > > Kevin Klues > >
