> On Jan. 13, 2016, 10:51 p.m., Gilbert Song wrote: > > src/uri/fetchers/docker.cpp, lines 435-437 > > <https://reviews.apache.org/r/42238/diff/1/?file=1195241#file1195241line435> > > > > Should this be possible? We may get an error when constructing URI > > protobuf as `path` is a required field.
Good catch! Thansk! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/#review114295 ----------------------------------------------------------- On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42238/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 11:14 p.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Bugs: MESOS-4296 > https://issues.apache.org/jira/browse/MESOS-4296 > > > Repository: mesos > > > Description > ------- > > Implemented the Docker URI fetcher plugin based on curl. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf > > Diff: https://reviews.apache.org/r/42238/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
