-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42320/#review114592
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Jan. 14, 2016, 10:06 p.m., Felix Abecassis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42320/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 10:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced "-m" with "--memory" for consistency ("-m" is not deprecated).
> 
> The short option "-c" is targeted for removal in version 1.11 of Docker:
> https://github.com/docker/docker/blob/851fe00c64ff/docs/misc/deprecated.md#command-line-short-variant-options
> 
> The long options are available since Docker 0.8.0:
> https://github.com/docker/docker/commit/e71dbf4ee5add5736f595948fc20bd01af56a744
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8 
> 
> Diff: https://reviews.apache.org/r/42320/diff/
> 
> 
> Testing
> -------
> 
> `make check` on my local desktop, the Docker tests did run:
> [----------] 7 tests from DockerTest
> [ RUN      ] DockerTest.ROOT_DOCKER_interface
> [       OK ] DockerTest.ROOT_DOCKER_interface (8897 ms)
> 
> Also checked that if I replace "-c" by a bogus value like "--foobar", the 
> tests failed.
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Reply via email to