-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114599
-----------------------------------------------------------


These issues ae based on offline discussions with bmahler.


src/tests/master_tests.cpp (line 23)
<https://reviews.apache.org/r/42212/#comment175464>

    Remove in favor of stringify.hpp in stout



src/tests/master_tests.cpp (line 3964)
<https://reviews.apache.org/r/42212/#comment175441>

    The array is now below, not above.



src/tests/master_tests.cpp (line 3965)
<https://reviews.apache.org/r/42212/#comment175440>

    The only real interesting cases here are with maxFrameworksArray = {0, 1, 
and 2}, with totalFrameworks = 2. This covers the case of maxFramworks == 0, 
something <= to the totalFrameworks launched, and something == to the total 
frameworks launched.  There is no need to go all the way up to the default, 
which may be raised in the future and cause things to slow down.



src/tests/master_tests.cpp (line 3987)
<https://reviews.apache.org/r/42212/#comment175465>

    Remove these obvious comments. Only add comments where the code itself is a 
little unclear in what it's doing.



src/tests/master_tests.cpp (line 4023)
<https://reviews.apache.org/r/42212/#comment175444>

    replace get() with -> as before.



src/tests/master_tests.cpp (line 4052)
<https://reviews.apache.org/r/42212/#comment175443>

    Array is now below.



src/tests/master_tests.cpp (line 4059)
<https://reviews.apache.org/r/42212/#comment175442>

    Also, change this to only cover 0,1,2 cases as above.



src/tests/master_tests.cpp (line 4148)
<https://reviews.apache.org/r/42212/#comment175445>

    ditto as above


- Kevin Klues


On Jan. 14, 2016, 4:11 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
>     https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number of frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> -------
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag"
>  make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to