----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42324/#review114604 -----------------------------------------------------------
Patch looks great! Reviews applied: [42324] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 14, 2016, 10:41 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42324/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 10:41 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van > Remoortere. > > > Bugs: MESOS-4301 > https://issues.apache.org/jira/browse/MESOS-4301 > > > Repository: mesos > > > Description > ------- > > Accepting an inverse offer will result in the master printing out "ACCEPT > call used invalid offers ...", even if all inverse offers are actually valid. > We silence the logs in this case. > > > Diffs > ----- > > src/master/master.cpp 863a11c82d322f56db1ccf25b73a4ffff1304a46 > > Diff: https://reviews.apache.org/r/42324/diff/ > > > Testing > ------- > > make check > > # Check the following for blank output > bin/mesos-tests.sh --gtest_filter="*Inverse*Offer*" --verbose 2>&1 /dev/null > | grep "ACCEPT call used invalid offers" > > > Thanks, > > Joseph Wu > >
