----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42331/#review114635 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos/containerizer.hpp (line 218) <https://reviews.apache.org/r/42331/#comment175487> no yours, why this is called 'scripts'? src/slave/containerizer/mesos/containerizer.cpp (line 862) <https://reviews.apache.org/r/42331/#comment175488> instead of 'launchInfo.get().has_rootfs()', you can do 'launchInfo->has_rootfs()' src/slave/containerizer/mesos/containerizer.cpp (line 866) <https://reviews.apache.org/r/42331/#comment175489> Ditto. You can do launchInfo->rootfs(). src/slave/containerizer/mesos/containerizer.cpp (line 900) <https://reviews.apache.org/r/42331/#comment175490> launchInfo->commands() src/slave/containerizer/mesos/containerizer.cpp (line 905) <https://reviews.apache.org/r/42331/#comment175491> Ditto. src/slave/containerizer/mesos/containerizer.cpp (line 907) <https://reviews.apache.org/r/42331/#comment175492> ditto. src/slave/containerizer/mesos/containerizer.cpp (lines 912 - 913) <https://reviews.apache.org/r/42331/#comment175493> Ditto. src/tests/containerizer/port_mapping_tests.cpp (line 320) <https://reviews.apache.org/r/42331/#comment175494> launchInfo->commands() src/tests/containerizer/port_mapping_tests.cpp (line 326) <https://reviews.apache.org/r/42331/#comment175495> Ditto. - Jie Yu On Jan. 15, 2016, 1:52 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42331/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 1:52 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4282 > https://issues.apache.org/jira/browse/MESOS-4282 > > > Repository: mesos > > > Description > ------- > > Update slave isolator prepare function using ContainerLaunchInfo. > > > Diffs > ----- > > include/mesos/slave/isolator.hpp 9c46a85680840ac26fe8f3f687a7d35c7eac1782 > include/mesos/slave/isolator.proto f4f93ca4957fa137c8132ee07929623c93ef380a > src/slave/containerizer/mesos/containerizer.hpp > f5303550d592b65717246e4d75c4355db9799073 > src/slave/containerizer/mesos/containerizer.cpp > 0639324a0bf489eed8b34bace9999e4f9f8d0872 > src/slave/containerizer/mesos/isolator.hpp > 6192b04c09d7b39352d3c3734ef4621a8acc629d > src/slave/containerizer/mesos/isolator.cpp > e49ecfa0034e2f22d1a501760961ab3f91841105 > src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp > d8310e6cf37de9ae4c10703be1d4f7155121ef2a > src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp > f37a3ef84f59ec9e4d0b68d8c192314a75398fdc > src/slave/containerizer/mesos/isolators/cgroups/mem.hpp > e17bb837b36682c8a754294d135282a9639cd819 > src/slave/containerizer/mesos/isolators/cgroups/mem.cpp > b4a53fed7d370b0c62926ba6fbc1ab3e2be81c91 > src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp > 9e084d812f686c99d5e65ce16a0126208b526a13 > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp > ed6697c971014372e60e496e48fe546cd522b0a8 > src/slave/containerizer/mesos/isolators/filesystem/linux.hpp > bdc9271ba751b7eced88ea7e11c87eae18fa5a61 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 39850aea516c12c1e2bfe233e758739ceddd3d6f > src/slave/containerizer/mesos/isolators/filesystem/posix.hpp > 19b0287889a416588ea7d5d5848a9dca3a369b6a > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > 6d141350aa8978b11a774aba3f571904695d1856 > src/slave/containerizer/mesos/isolators/filesystem/shared.hpp > 186b5d1306f274b6428c520b0780bf3a6788fc80 > src/slave/containerizer/mesos/isolators/filesystem/shared.cpp > e052da0442978a662375728863a67d3c8eb4b8ed > src/slave/containerizer/mesos/isolators/namespaces/pid.hpp > 6d611554de7dab47b89dea9293d470c9668c1ed6 > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > 36b9dd84ba1af211c3b7491edc99a924830993eb > src/slave/containerizer/mesos/isolators/network/port_mapping.hpp > b4097b5562aa30a0c190f5faa295b1ef473e7763 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > efc87e07bd7d3852d54531eed723a3d207a25b01 > src/slave/containerizer/mesos/isolators/posix.hpp > 3d628aa3cef33e4bf8d87629aae508458ed7dfa1 > src/slave/containerizer/mesos/isolators/posix/disk.hpp > cbb4f39db80898199df3361b5f2549a63aff3f6e > src/slave/containerizer/mesos/isolators/posix/disk.cpp > 075a4ec9714a71459127eb9b63c9b6aa410aa8fa > src/tests/containerizer/isolator.hpp > 876484688abe0fc05d484fd65aaf4d6f2d6e40aa > src/tests/containerizer/isolator_tests.cpp > 9f67a2af5830dfffe6302268d08514b06ee81e61 > src/tests/containerizer/mesos_containerizer_tests.cpp > 00ae7398b9b763c54ba38d19e1275c1dace3f0eb > src/tests/containerizer/port_mapping_tests.cpp > 582df8a9d2b7fe80cd6b0c15ac33bc7d45536a61 > > Diff: https://reviews.apache.org/r/42331/diff/ > > > Testing > ------- > > make check > sudo ./bin/mesos-test.sh > > > Thanks, > > Gilbert Song > >
