> On Jan. 14, 2016, 4:14 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 659
> > <https://reviews.apache.org/r/41593/diff/16/?file=1195136#file1195136line659>
> >
> >     Why do you need to pull this variable out?

This is consistent from the original code.


> On Jan. 14, 2016, 4:14 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 637
> > <https://reviews.apache.org/r/41593/diff/16/?file=1195136#file1195136line637>
> >
> >     Are you pulling this variable out to optimize away the calls to 
> > `field_count()`?

It looks like it. Synced with BenH offline, and we agreed this is ok.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/#review114398
-----------------------------------------------------------


On Jan. 15, 2016, 4 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41593/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 4 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 5ab7bc4966fe32eaddd573a4dbfd997f98b5d481 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> f32493f90f3bc2a62119dcea49eb5f4966388bf5 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 017cef466a30e73af36d72332514a4dbb2beb6bc 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 62ad461eb228b688f1ceac16cfb003561ed5a806 
>   3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> 34bb2523ebf3d6d390cbfe1623b89fae0053b712 
> 
> Diff: https://reviews.apache.org/r/41593/diff/
> 
> 
> Testing
> -------
> 
> Added tests to `<stout/jsonify_tests.cpp>`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to